Skip to content

[Common] Add ZDC & FIT time tables and kIsBBZPA && kIsBBZPC selections to centrality study - #17347

Merged
ddobrigk merged 1 commit into
AliceO2Group:masterfrom
jesgum:zdc-time
Aug 12, 2026
Merged

[Common] Add ZDC & FIT time tables and kIsBBZPA && kIsBBZPC selections to centrality study#17347
ddobrigk merged 1 commit into
AliceO2Group:masterfrom
jesgum:zdc-time

Conversation

@jesgum

@jesgum jesgum commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Tagging @ddobrigk

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 8 errors, ⚠️ 2 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title Add ZDC & FIT time tables and kIsBBZPA && kIsBBZPC selections to centrality study [Common] Add ZDC & FIT time tables and kIsBBZPA && kIsBBZPC selections to centrality study Aug 5, 2026
@jesgum
jesgum marked this pull request as ready for review August 5, 2026 15:34
@alibuild

alibuild commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for f19ba10 at 2026-08-10 17:49:

## sw/BUILD/O2Physics-latest/log
c++: fatal error: Killed signal terminated program cc1plus
c++: fatal error: Killed signal terminated program cc1plus
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for f19ba10 at 2026-08-11 03:21:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 6 errors and 0 warnings.'
Found 6 errors and 0 warnings.
++ [[ 6 -gt 0 ]]
++ cat /sw/BUILD/2d1204a3591e882d4f6ebe1aac39230b21cb44d4/O2Physics-code-check/errors.txt
Common/TableProducer/multiplicityExtraTable.cxx:41:10: error: inclusion of deprecated C++ header 'stdlib.h'; consider using 'cstdlib' instead [modernize-deprecated-headers,-warnings-as-errors]
Common/TableProducer/multiplicityExtraTable.cxx:108:42: error: implicit conversion 'bool' -> 'value_type' (aka 'int') [readability-implicit-bool-conversion,-warnings-as-errors]
Common/TableProducer/multiplicityExtraTable.cxx:116:47: error: implicit conversion 'bool' -> 'value_type' (aka 'int') [readability-implicit-bool-conversion,-warnings-as-errors]
Common/TableProducer/multiplicityExtraTable.cxx:140:41: error: implicit conversion 'value_type' (aka 'int') -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
Common/TableProducer/multiplicityExtraTable.cxx:264:35: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
Common/TableProducer/multiplicityExtraTable.cxx:267:35: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 6 -gt 0 ]]
++ exit 1
--

Full log here.

@ddobrigk
ddobrigk merged commit 518eee1 into AliceO2Group:master Aug 12, 2026
12 of 14 checks passed
@jesgum
jesgum deleted the zdc-time branch August 12, 2026 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants